Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero degree polynomials in Trend (a mean) #162

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

leouieda
Copy link
Member

There was no real reason to not allow them in the past. A zero degree
polynomial is a mean. This can be useful to test if a simple static
shift in the data is enough of a trend.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

There was no real reason to not allow them in the past. A zero degree
polynomial is a mean. This can be useful to test if a simple static
shift in the data is enough of a trend.
@leouieda leouieda merged commit 24416cf into master Dec 19, 2018
@leouieda leouieda deleted the trend_zero branch December 19, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant