Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow block_split and BlockReduce to take a shape #184

Merged
merged 1 commit into from
May 14, 2019

Conversation

leouieda
Copy link
Member

block_split and BlockReduce/BlockMean (which relied on it) only
allowed defining the block size by spacing. Now they an take a shape
as well. Useful when the size of the block is less meaningful than the
number of blocks (like in spatial cross-validation splitting).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

`block_split` and `BlockReduce`/`BlockMean` (which relied on it) only
allowed defining the block size by `spacing`. Now they an take a `shape`
as well. Useful when the size of the block is less meaningful than the
number of blocks (like in spatial cross-validation splitting).
@leouieda leouieda merged commit 42dda32 into master May 14, 2019
@leouieda leouieda deleted the block-split-shape branch May 14, 2019 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant