Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for VectorSpline2D #214

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Conversation

leouieda
Copy link
Member

Refer users to the implementation in Erizo instead
(https://github.com/fatiando/erizo). Remove the respective gallery
example since we don't want people using this class. In the Vector data
tutorial, point people to Erizo and include the deprecation warning.
See #205.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Refer users to the implementation in Erizo instead
(https://github.com/fatiando/erizo). Remove the respective gallery
example since we don't want people using this class. In the Vector data
tutorial, point people to Erizo and include the deprecation warning.
See #205.
Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I think the texts are sufficiently clear and show the differences between the uncoupled interpolation made by vd.Vector and coupled one that is applied by Erizo.

@leouieda leouieda merged commit d4ed31b into master Nov 29, 2019
@leouieda leouieda deleted the vectorspline-deprecation branch November 29, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants