-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set numba config for each jit function #221
Conversation
Using `parallel=True` on the Green's function was raising a warning because there is nothing to parallelize. Set arguments individually to avoid this. Add missing `numba.prange` to Spline Jacobian calculation to actually run it in parallel.
Tests were failing in Windows with numba because of small changes in the numerical values. Make the search parameters more different to account for this.
Threads aren't implemented for Python 3.8 on Windows.
I think #222 might fix some of these failures so waiting on that. |
For some reason, the Dask related tests and docs hang in CI when using numba. I can't reproduce locally so it's hard to pin point. Will try removing the |
Alright, using the numpy engine with the dask tests seems to work. Strange because the tutorials work. |
Merging this in since things seem to be working. |
Using
parallel=True
on the Green's function was raising a warningbecause there is nothing to parallelize. Set arguments individually to
avoid this. Add missing
numba.prange
to Spline Jacobian calculation toactually run it in parallel.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
andverde/__init__.py
.