Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set numba config for each jit function #221

Merged
merged 9 commits into from
Jan 21, 2020
Merged

Conversation

leouieda
Copy link
Member

Using parallel=True on the Green's function was raising a warning
because there is nothing to parallelize. Set arguments individually to
avoid this. Add missing numba.prange to Spline Jacobian calculation to
actually run it in parallel.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Using `parallel=True` on the Green's function was raising a warning
because there is nothing to parallelize. Set arguments individually to
avoid this. Add missing `numba.prange` to Spline Jacobian calculation to
actually run it in parallel.
@leouieda leouieda added this to the v1.3.0 milestone Jan 16, 2020
Tests were failing in Windows with numba because of small changes in the
numerical values. Make the search parameters more different to account
for this.
Threads aren't implemented for Python 3.8 on Windows.
@leouieda
Copy link
Member Author

I think #222 might fix some of these failures so waiting on that.

@leouieda
Copy link
Member Author

For some reason, the Dask related tests and docs hang in CI when using numba. I can't reproduce locally so it's hard to pin point. Will try removing the parallel arg from numba to see if that's the problem.

@leouieda
Copy link
Member Author

Alright, using the numpy engine with the dask tests seems to work. Strange because the tutorials work.

@leouieda
Copy link
Member Author

Merging this in since things seem to be working.

@leouieda leouieda merged commit f91059c into master Jan 21, 2020
@leouieda leouieda deleted the numba-parallel branch January 21, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants