Replace pylint with more flake8 plugins #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following fatiando/harmonica#285, replace pylint with a bunch of new flake8 plugins. They cover most of the checks that were performed before, add a few new ones, and are less troublesome to maintain and silence when necessary. Fixes the formatting issues raised after applying the changes: making tutorials/examples fit 79 char comments/docstrings, silence a few issues because of scikit-learn style code, reorder imports because of isort. I also combined the CI checks into only 2: "format" and "style". If formatting is broken, we don't need to know which one is complaining, just run
make format
. And style is now only flake8 anyway.Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.