Fix behavior if spacing >= 2 * interval #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bug caused by the rounding when calculating the number of nodes in `spacing_to_size`. For the case where the spacing is larger than twice the interval, the size calculating rounded to zero which meant that we were getting a single value for the number of nodes. This is clearly wrong since our behavior is to change the spacing or the region to make sure we always produce at least 2 nodes in the interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug caused by the rounding when calculating the number of nodes in
spacing_to_size. For the case where the spacing is larger than twice the interval, the size calculating rounded to zero which meant that we were getting a single value for the number of nodes. This is clearly wrong since our behavior is to change the spacing or the region to make sure we always produce at least 2 nodes in the interval.Relevant issues/PRs:
Fixes #404