Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropping non-dimensional coordinates in grid_to_table #441

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Fix dropping non-dimensional coordinates in grid_to_table #441

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e60b5f
Account extra coordinates in the function grid_to_table
Souza-junior Apr 6, 2024
633c73c
Solve PR issues
Souza-junior Apr 6, 2024
bb3d762
Add test for grid with extra coordinates
Souza-junior Apr 8, 2024
e33a6ac
Merge branch 'main' into main
leouieda Apr 11, 2024
fddc70b
Fix documentation line too long
leouieda Apr 11, 2024
52ef281
Fix formatting
leouieda Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions verde/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,11 @@
# Need to flip the coordinates because the names are in northing and
# easting order
coordinates = [i.ravel() for i in np.meshgrid(east, north)][::-1]
# Identify and add extra coordinates
extra = [coord for coord in grid.coords.keys() if coord not in coordinate_names]
for coord in extra:
coordinates.append(grid[coord].values.ravel())
coordinate_names.append(coord)

Check warning on line 644 in verde/utils.py

View check run for this annotation

Codecov / codecov/patch

verde/utils.py#L643-L644 

Added lines #L643 - L644 were not covered by tests
data_dict = dict(zip(coordinate_names, coordinates))
data_dict.update(dict(zip(data_names, data_arrays)))
return pd.DataFrame(data_dict)
Expand Down
Loading