Add "comment" mode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to get the start/end information for a comment block, so
an "ac" ("a comment") textobj can be added to vim-go.
fatih
reviewed
Apr 8, 2018
.travis.yml
Outdated
| go: | ||
| - 1.6 | ||
| go: | ||
| - 1.7 |
There was a problem hiding this comment.
While you're at, can you can change this to 1.10.x ?
fatih
reviewed
Apr 8, 2018
| } | ||
|
|
||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
The error is already checked above. This is just to prevent a nil pointer reference in out.Comment below in the tests where we expect err to be non-nil.
|
Thanks @Carpetsmoker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to get the start/end information for a comment block, so
an "ac" ("a comment") textobj can be added to vim-go.