GetInfo() echoes its result instead of a string return

[illotum]

What did you do? (required. The issue will be closed when not provided.)

Assigned go#complete#GetInfo() to a variable.

What did you expect to happen?

String variable and no echo.

What happened instead?

GetInfo end up calling s:info_complete and the result is echoed.

This must be a fairly recent regression, I used this exact setup about a year ago successfully.

Configuration (MUST fill this out):

• vim-go version: a6e62dc

• vimrc you used to reproduce: https://gist.github.com/illotum/ae87de1033c9ad33e6e2ad77e112b87c

• Vim version (first three lines from :version):

NVIM v0.3.1
Build type: Release
LuaJIT 2.0.5

• Go version (go version):

go version go1.10.3 darwin/amd64

• Go environment (go env):

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/alexv/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/alexv"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.3/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/yr/m790wsnd4h7gv5hknqhb7yq4
0000gn/T/go-build219756745=/tmp/go-build -gno-record-gcc-switches -fno-common"

[bhcleek]

@illotum can you give #1905 a try?

[illotum]

@bhcleek Your branch returns 0 and still echoes the contents. If I comment out LL224-226 the echo part is gone, but the return is printed out as 0 anyways.

To clarify, according to docs GetInfo() is supposed to return description without any side effects:

Returns the description of the identifer under the cursor. Can be used to plug into the statusline.

[bhcleek]

Thanks for teseting @illotum . I amended the PR. Can you try again?

[illotum]

This one works, thank you!

If I may piggyback, related question:

For some reason, status is being properly filled through this exists call, but info is only printed out if I assign it directly (commented out), otherwise it stays set to "L". Are these two functions defined differently?

        function! GoStatus()
            let l:status = exists('*go#statusline#Show') ? go#statusline#Show() : 'S'
            let l:info = exists('*go#complete#GetInfo') ? go#complete#GetInfo() : 'L'
            " let l:info = go#complete#GetInfo()
            return printf('%s %s', l:status, l:info)
        endfunction

[bhcleek]

It's probably because at the time exists(*go#complete#GetInfo) executes, the autoload/go/complete file hasn't been loaded, because nothing else has referenced a function in it yet, so exists returns false.