Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.8 compatible GOPATH improvements #1248

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Go 1.8 compatible GOPATH improvements #1248

merged 1 commit into from
Mar 30, 2017

Conversation

fatih
Copy link
Owner

@fatih fatih commented Mar 29, 2017 •
edited
Loading

This PR fixes the following cases:

  • If no GOPATH is set, vim-go uses the default GOPATH via go env GOPATH (starting Go 1.8)
  • :GoPath now shows the correct GOPATH if no GOPATH is set
  • :GoInstallBinaries now installs to the correct GOPATH if no GOPATH
    is set

fixes #1243 #1208

@fatih
Copy link
Owner Author

fatih commented Mar 29, 2017

@spf13 can you try this branch? I've removed my GOPATH via unset GOPATH and then just started vim-go. It should now without issues.

@fatih fatih mentioned this pull request Mar 29, 2017
Closed
@kron4eg
Copy link

kron4eg commented Mar 29, 2017 •
edited
Loading

@fatih I'm getting

Error detected while processing function <SNR>53_fmt_autosave[3]..go#fmt#Format[40]..go#fmt#run:
line    2:
E691: Can only compare List with List

When I'm trying to save. On master branch it's all good (expect default GOPATH obviously :) )

@fatih
Go 1.8 compatible GOPATH improvements
6db12a9 
This PR fixes the following cases:

* If no GOPATH is set, vim-go uses the default GOPATH via `go env
  GOPATH` (starting Go 1.8)
* `:GoPath` now shows the correct `GOPATH` if no GOPATH is set
* `:GoInstallBinaries` now installs to the correct GOPATH if no GOPATH
  is set

fixes #1243
@fatih
Copy link
Owner Author

fatih commented Mar 29, 2017

@kron4eg there was a bug, I've fixed and pushed to this branch (amended). I'm also testing it currently during my work. Please don't hesitate to give any feedback and thanks! :)

@kron4eg
Copy link

kron4eg commented Mar 29, 2017

Yep, now it works, all good. As well as default GOPATH. Thanks @fatih!

@fatih fatih merged commit 727aed3 into master Mar 30, 2017
@fatih fatih deleted the default-gopath branch March 30, 2017 00:11
@fatih fatih mentioned this pull request Mar 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default GOPATH not respected in vim-go
2 participants
@fatih @kron4eg