Show multiline errors #1456
Show multiline errors #1456
Conversation
|
lgtm |
There was a problem hiding this comment.
I agree that this makes things look better, but I am not sure I would expect a new message to be added to message history for each line in the message; I think we should consider carefully whether that's really what vim-go should be doing. Just food for thought...
I'd also like to recommend that EchoSuccess, EchoProgress, EchoInfo, and maybeEchoWarning not append to message history; I think those commands should be using echo instead of echom.
autoload/go/util.vim
Outdated
| redraw | echohl ErrorMsg | echom "vim-go: " . a:msg | echohl None | ||
| endfunction | ||
| " Tabs display as ^I or <09>, so manually expand them. | ||
| let l:msg = map(l:msg, 'substitute(v:val, "\t", " ", "")') |
There was a problem hiding this comment.
Perhaps tabs should be expanded according to the value of &ts?
There was a problem hiding this comment.
We could, but a tab width of 8 is kind of standard in terminals, so I think that 8 spaces makes more sense here than the tabstop setting.
Are there any downsides to this? As far as I know it's just how it appears on the screen and in
Maybe? Not sure. I understand why someone would prefer that, but on the other hand I personally prefer to have a complete message history. |
|
The downside that I see is that message history is limited to 200 messages. Often, that may not be a problem, but for some messages it could very easily end up dropping necessary information (e.g. when I don't feel strongly about either of these things, but wanted to throw it out there for consideration. |
Unlike `:echo`, `:echom` is rather stupid. It will display a newline as `^@` or `<00>` and tabs as `^I` or `<09>` (depending on the `display` setting). This some messages display nicer, for example `:GoBuild --` looked rather confusing before, and looks as expected now. This fixes some – but not all – of #1429.
Also combine declaration/assignment in one entry while I'm here.
Unlike
:echo,:echomis rather stupid. It will display a newline as^@or<00>and tabs as^Ior<09>(depending on thedisplaysetting).
This some messages display nicer, for example
:GoBuild --lookedrather confusing before, and looks as expected now.
Before:
After:
Needs some more testing (Vim 7.4, Neovim), but seems to work well.
This fixes some – but not all – of #1429.