Homogenize async progress #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only echo status when g:go_echo_command_info is set. * Echo status when starting a job.
* Make sure all async jobs set the statustype option key so that their progress will be echoed appropriately. * Move some progress messages that were written just prior to starting an async job to be written just before executing the similar synchronous execution (e.g. in `go#cmd#Test`). * Move the "analysing with scope" message in guru so that it will be written _after_ the async job is started and make sure it's guarded by a `go#config#EchoProgress` check. * Remove remaining progress messages that were written just prior to starting async jobs.
bhcleek
force-pushed
the
homogenize-async-progress
branch
from
c90ca03
to
6e6abbc
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobs: improve progress echo
improve use of statustype and progress messages
progress will be echoed appropriately.
an async job to be written just before executing the similar
synchronous execution (e.g. in
go#cmd#Test).written after the async job is started and make sure it's guarded by
a
go#config#EchoProgresscheck.starting async jobs.