support and test against Go 1.11 #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update errorformat strings for go test for Go 1.11 test output while maintaining compatibility with Go 1.10 test output, too. The changes were validated locally by running the tests in vim-go-test containers based on the respective versions of Go. I investigated trying to use the json support, but it doesn't offer any real value for us yet. I may revisit it later. Update the go vet expecations; one of the strings changed. Update to the Dockerfile base image and travis to use Go 1.11.
|
lgtm |
bhcleek
added a commit
that referenced
this pull request
Sep 19, 2018
arp242
added a commit
to arp242/gopher.vim
that referenced
this pull request
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update errorformat strings for go test for Go 1.11 test output while
maintaining compatibility with Go 1.10 test output, too. The changes
were validated locally by running the tests in vim-go-test containers
based on the respective versions of Go. I investigated trying to use the
json support, but it doesn't offer any real value for us yet. I may
revisit it later.
Update the go vet expecations; one of the strings changed.
Update to the Dockerfile base image and travis to use Go 1.11.