refactor autocmd configuration #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the commented out experimental code for highlighting the uses of a particular identifier. The feature was implemented a couple of years ago, and then commented out experimental code no longer serves any purpose.
Refactor ftdetect/gofiletype.vim so that it _only_ sets filetype; it no longer sets fileformat or fileencoding. fileformat and fileencoding are now set by autocmd events configured in plugin/go.vim Move most functions called by autocmd events into autoload/go/auto.vim. The only exceptions are s:gofiletype_pre and s:gofiletype_post in plugin/go.vim. Consistently use `setfiletype`; previously `set filetype` was used for gohtmltmpl and gomod files. Change s:gofiletype_pre in plugin/go.vim so that it does not set the filetype; it's already set in ftdetect/go.vim and setting it again may cause problems for any user that needs to set it to something else. Move the configuration of all autocmd events that occur after the FileType event into ftplugin files and clear them in undo_ftplugin so that they will not execute if the filetype is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove commented out experimental SameID code
Remove the commented out experimental code for highlighting the uses of
a particular identifier. The feature was implemented a couple of years
ago, and then commented out experimental code no longer serves any
purpose.
refactor autocmd events
Refactor ftdetect/gofiletype.vim so that it only sets filetype; it no
longer sets fileformat or fileencoding. fileformat and fileencoding are
now set by autocmd events configured in plugin/go.vim
Move most functions called by autocmd events into autoload/go/auto.vim.
The only exceptions are s:gofiletype_pre and s:gofiletype_post in
plugin/go.vim.
Consistently use
setfiletype; previouslyset filetypewas used forgohtmltmpl and gomod files.
Change s:gofiletype_pre in plugin/go.vim so that it does not set the
filetype; it's already set in ftdetect/go.vim and setting it again may
cause problems for any user that needs to set it to something else.
Move the configuration of all autocmd events that occur after the
FileType event into ftplugin files and clear them in undo_ftplugin so
that they will not execute if the filetype is changed.