use make for GoInstall to correctly parse error paths #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
added a commit
that referenced
this pull request
Jan 20, 2016
use make for GoInstall to correctly parse error paths
|
Thanks @jellevandenhooff for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I ran into a regression of #404 (where
:GoInstalldid not parse the paths in the output correctly.)I fixed my issue locally with this PR by scavenging some logic from
go#cmd#Build. However, I don't really know what I'm doing, so if there is a better way to fix this issue, let me know.Thanks,