cmd, jobcontrol: add progress and complete message for nvim #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to work GoTestFunc. refs fatih#686
| @@ -183,14 +184,19 @@ function! go#cmd#Test(bang, compile, ...) | |||
| " expand all wildcards(i.e: '%' to the current file name) | |||
| let goargs = map(copy(a:000), "expand(v:val)") | |||
|
|
|||
| " escape all shell arguments before we pass it to test | |||
| call extend(args, go#util#Shelllist(goargs, 1)) | |||
| call extend(args, goargs, 1) | |||
There was a problem hiding this comment.
I guess that a recent change 579dd89 broke go#cmd#GoTestFunc because go#util#Shelllist also escapes "-run" flag.
GoTestFunc passes goargs that contains "-run=TestABC" but go#util#Shelllist escapes that flag.
fatih
added a commit
that referenced
this pull request
Jan 28, 2016
cmd, jobcontrol: add progress and complete message for nvim
|
Thanks @t-yuki 👍 |
|
Is there any way to disable these messages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd, jobcontrol: add progress and complete message for nvim.
cmd: fix to work GoTestFunc.
refs #686