v1.3.0 (re-release due to violation of semantic versioning)

[FND]

v1.2.{1,2} will be deprecated

in the process, updated dependencies and revised changelog

• ensure new path resolution (details in dc5e207) does not lead to any obvious backwards-compatibility issues (e.g. with faucet-sass - i.e. I hope legacy behavior was never actually being used)
  cf. require.resolve regression in Node v12 with paths nodejs/node#29139 (comment)

• revise changelog for consistency

• update release date in changelog

• release v1.3.0

• deprecate v1.2.x ("re-released as v1.3.0 due to violation of semantic versioning"?)

  $ npm deprecate faucet-pipeline-core@"~1.2.1" "$msg"
  

[moonglum]

Yep, looks like a good fix 👍

[FND]

Update: This was an intentional change in Node v12 - see nodejs/node#29139 and dc5e207 for details.

reduced test case:

/path/to/faucet-core/test/fixtures
├── dummy
│   ├── index.js
│   └── src.js
└── node_modules
    └── dummy
        ├── index.js
        └── pkg.js

$ cd /tmp
$ node -e 'require.resolve("dummy/src.js", { paths: ["/path/to/faucet-core/test/fixtures"] })'
Error: Cannot find module 'dummy/src.js'

This only fails on Node v12 though; both v8 and v10 work as expected.

However, I would argue that test (introduced in 3142f2e) makes no sense: Why would dummy/src.js resolve to ./dummy/src.js; that's only supposed to work for ./node_modules/dummy/src.js, no? I'm uncertain whether that was just a case of us being a little careless or whether there's more to this (think backwards compatibility).

[moonglum]

Yes, this behavior was unintentional. Thanks for fixing it! I say: Let's release this.