OSS-1033 Fix non-nullable Select default parameter type
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`null` is a valid value in FQL
winghouchan
force-pushed
the
fix-non-nullable-select-default-param-type
branch
from
5f439d4
to
2dbec6e
Compare
|
Internal ticket number is OSS-1033 |
ptpaterson
changed the title
Select default parameter typeSelect default parameter type
|
Was there a reason for closing this? |
|
Apologies, we had to do some branch cleaning and the branch you posted against was removed. We need to reopen this against |
|
Ok, I've reopened in #636 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
nullis a valid value in FQL. Fixes #583.How to test
nullto the default parameter ofSelect. No type error should be raised.Screenshots
N/A