Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-2590] add client endpoint param #652

Merged
merged 6 commits into from
Aug 12, 2022
Merged

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Aug 11, 2022

Notes

Jira Ticket

The endpoint parameter is supported by other drivers. Implement it for the JS driver.

Those drivers that support endpoint do not support the scheme + domain + port parameters, so we need to determine how to handle the case where endpoint and the others are included. My suggestion is that if endpoint is set, then the other three are ignored, and that is what this PR does.

The JS driver accepts and optional argument with override options for the client.query and client.queryWithMetrics methods, but any overrides for scheme, domain, or port will not have any effect. No additional checks are required to handle query options.

Use cases

  • The /linearized endpoint is not currently useable with the python driver. Or at least not reasonably. You can specify the port as 443/linearized to make it work, but it is not reasonable to advise folks to do this.
  • arbitrary endpoints are not currently possible. For example if you want to send requests through a proxy. Again, you can most likely work around this by hacking the port parameter.

How to test

A test was added. No changes in environment or configuration are required to run the test.

@ptpaterson ptpaterson changed the title Fe 2590 add client endpoint param [FE-2590] add client endpoint param Aug 11, 2022
@ptpaterson ptpaterson merged commit 83623a3 into v4 Aug 12, 2022
@ptpaterson ptpaterson deleted the FE-2590-add-client-endpoint-param branch August 12, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants