Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client => FaunaClient #99

Merged
merged 2 commits into from
Oct 26, 2016
Merged

Client => FaunaClient #99

merged 2 commits into from
Oct 26, 2016

Conversation

marrony
Copy link
Contributor

@marrony marrony commented Oct 20, 2016

To make it more consistent with other drivers

ashfire908
ashfire908 reviewed Oct 20, 2016
View reviewed changes
Copy link
Contributor

@ashfire908 ashfire908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the references to the client in the docs as well.

@marrony
Copy link
Contributor Author

marrony commented Oct 25, 2016

Did you refer to core docs? If it is I created the docs there using FaunaClient

@ashfire908
Copy link
Contributor

No, the driver internal docs. Specifically, you have to update docs/client.rst (though I would grep around to make sure there isn't anything else that needs to be updated as well).

ashfire908
ashfire908 approved these changes Oct 25, 2016
View reviewed changes
Copy link
Contributor

@ashfire908 ashfire908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@marrony marrony mentioned this pull request Oct 26, 2016
Merged
@ashfire908 ashfire908 merged commit b0560a7 into master Oct 26, 2016
@ashfire908 ashfire908 deleted the rename_client branch October 26, 2016 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfire908 ashfire908 ashfire908 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marrony @ashfire908