Case insensitive :contains?

[ganeshv]

Is there a way to do a case insensitive :contains? If not, would :icontains be an acceptable enhancement? I'm willing to do the coding.

[fb55]

Having an i after the searched string might be a nice addition: Eg. :contains("AnY WaY You wAnt To Spell" i). This is already implemented for attributes, but would require changes to css-what.

[ganeshv]

The possible issue with that syntax is

:contains(anything i)
:contains("anything" i)
:contains("anything i")

would have different semantics, which is not immediately clear at first glance. If :contains had historically forced the use of quotes, or had a different form (e.g. :contains=) it would be a simpler choice.

IMHO icontains is sort of familiar - Django uses it, and there is even a JQuery plugin to supplement its :contains selector called jquery.icontains

[fb55]

I would only do a case-insensitive search for the second of your examples, but I see your point. The Django example isn't exactly for CSS selectors, but I would be fine with it. As always: Pull requests welcome :)

[ganeshv]

Hi @fb55, the code was pretty easy, but I could do with some guidance on adding tests. I assume you've copied tests from sizzle and qwery and so on. Which set should I insert the :icontains tests?

[fb55]

I would create a new file in the test directory (perhaps icontains.js), then use the format of attributes.js, which already contains the case-insensitive test cases for attributes :).

[fb55]

Fixed in #34