pseudos: implement :icontains, case-insensitive version of :contains #34
Conversation
| icontains: function(next, text){ | ||
| return function icontains(elem){ | ||
| return next(elem) && | ||
| getText(elem).toLowerCase().indexOf(text.toLowerCase()) >= 0; |
There was a problem hiding this comment.
text.toLowerCase() can be called while compiling (can be moved out of the returned function).
|
One small improvement and this is good to go :) |
ganeshv
force-pushed
the
icontains
branch
2 times, most recently
from
03b5dfb
to
459714e
Compare
|
Updates: moved the text.toLowerCase() outside and fixed up tabs, rebased and squished it into the same commit. |
| @@ -0,0 +1,87 @@ | |||
| var CSSselect = require("../"), | |||
| makeDom = require("htmlparser2").parseDOM, | |||
| falseFunc = require("boolbase").falseFunc, | |||
|
Whee, sorry, failed to check this again. jshint produced two errors (see comments), do you want to fix them? |
|
OK, fixed the above two, rebased to master, squashed into single commit. |
|
@ganeshv One of your test cases is still failing: |
|
For that test to pass, it needs css-what with my other pull request which you have already merged. Manually copying index.js from css-what/master to node_modules/... does get the test to pass. Let me know how to proceed. (Sorry for the back and forth, I'm kinda new to the node.js ecosystem. Thanks for your patience.) |
|
Okay, my bad. I've published a new |
pseudos: implement :icontains, case-insensitive version of :contains
pseudos: implement :icontains, case-insensitive version of :contains
As discussed in issue 33, with tests.
One of the tests fails and needs a corresponding fix in css-what to strip the quotes of
icontainsdata. I have opened a separate PR for that issue.