fix(parse): Throw errors when encountering multiple traversals in a row

Eg. `<>` is no longer a valid selector
fb55 · Oct 12, 2020 · f07d582 · f07d582
1 parent 8f64671
commit f07d582
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/parse.spec.ts b/src/parse.spec.ts
@@ -18,3 +18,26 @@ describe("Collected selectors", () => {
         }
     });
 });
+
+const broken = [
+    "[",
+    "(",
+    "{",
+    "()",
+    "<>",
+    "{}",
+    ",",
+    ",a",
+    "a,",
+    "[id=012345678901234567890123456789",
+    "input[name=foo.baz]",
+    "input[name=foo[baz]]",
+];
+
+describe("Broken selectors", () => {
+    for (const selector of broken) {
+        it(`should not parse — ${selector}`, () => {
+            expect(() => parse(selector)).toThrow(Error);
+        });
+    }
+});
diff --git a/src/parse.ts b/src/parse.ts
@@ -211,6 +211,12 @@ function parseSelector(
         return (slashCount & 1) === 1;
     }
 
+    function ensureNotTraversal() {
+        if (tokens.length > 0 && isTraversal(tokens[tokens.length - 1])) {
+            throw new Error("Did not expect successive traversals.");
+        }
+    }
+
     stripWhitespace(0);
 
     while (selector !== "") {
@@ -220,6 +226,7 @@ function parseSelector(
             sawWS = true;
             stripWhitespace(1);
         } else if (firstChar in Traversals) {
+            ensureNotTraversal();
             tokens.push({ type: Traversals[firstChar] });
             sawWS = false;
 
@@ -235,6 +242,7 @@ function parseSelector(
         } else {
             if (sawWS) {
                 if (tokens.length > 0) {
+                    ensureNotTraversal();
                     tokens.push({ type: "descendant" });
                 }
                 sawWS = false;