refactor(trie): Simplify trie, add documentation #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates 612 branches.
This removes the need for additional branches, and results in a better experience for the edge case of a branch that was already encoded.
With the last change, they should be encoded the same as other nodes with single branches. This made the map 10% smaller for some reason.
This reverts commit ef4958a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use prefixes in the trie representation, and generate the same structure when serialising the trie instead. Consequently, single-value branches now have the same structure every time. We now also merge shared suffixes, for some additional space savings.
These changes lead to a ~10% reduction in the size of the HTML trie array.