Possibly fixes #175, added custom Exception classes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `FBchatException`, `FBchatFacebookError` and `FBchatUserError`, which can help in differentiating between errors
Requests would sometimes throw an error while retrieving the c_user cookie (If there were multiple cookies with this name)
Thereby also moving ReqUrl to self.req_url
madsmtm
commented
Sep 19, 2017
| @@ -157,11 +199,14 @@ def _postLogin(self): | |||
| self.payloadDefault = {} | |||
| self.client_id = hex(int(random()*2147483648))[2:] | |||
| self.start_time = now() | |||
| self.uid = str(self._session.cookies['c_user']) | |||
| self.uid = self._session.cookies.get_dict().get('c_user') | |||
There was a problem hiding this comment.
This would probably also fix #198, since requests.session.cookies works kinda wierd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175 (502 response):
You would get either a 502 or a 503 response from Facebook's pull-servers once in a while.
Proposed fix is to change the pull-channel, and refresh the
self.sticky/self.poolparameters.I don't quite remember my tests, but I'm pretty sure that refreshing the sticky/pool parameters were nescessary. I'm not sure I actually double-checked that changing the pull-channel was nescessary, but it's something that I've noticed the Facebook-webclient does.
Other than that:
doOneListenloop has been improved.FBchatException,FBchatFacebookErrorandFBchatUserErrorReqUrltoself.req_url, so that we can change pull channelsThis is still untested for long amounts of time, will do that before merging