Remove deprecated methods #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMnet
approved these changes
Oct 30, 2023
|
@aartigao @LMnet The MiMA errors here are actually real and letting us know we're breaking binary compatibility. I saw these changes were released in v3.3.0 as a minor version release, but since they break binary compatibility, they need to be removed as part of a major release (v4.0.0). Should we revert these changes and release v3.3.1? |
|
Oh! Shame on me... sorry! I'll fix it ASAP. Just reverting this commit is fine, right? |
Reverting ebb36b2 should be enough. :) |
aartigao
added a commit
to aartigao/fs2-kafka
that referenced
this pull request
Feb 16, 2024
This reverts commit 6f8804c
aartigao
added a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a long time since 3.x was published and users have had enough time to stop using these deprecated methods.