Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin dependencies under sbt-typelevel umbrella #1297

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

aartigao
Copy link
Contributor

On mdoc execution issue

Latest mdoc is compiled with JDK 11 but our GHA publish job was configured to use JDK 8:

[info] running fs2.kafka.docs.Main 
Error: Exception in thread "sbt-bg-threads-1" java.lang.UnsupportedClassVersionError: mdoc/MainSettings$ has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

👆🏽 See this run log for the full error.

By switching the order of githubWorkflowJavaVersions the issue should be fixed, because the first JDK defined (in the case of this PR, JDK 21) is the one used for the publish job. I'm pretty sure that this doesn't affect anything else because we're only using a newest JVM to run but the release flag is set to JDK 8, thus compiled bytecode will be compatible with old Java versions.

The build job still runs in JDK 8 and JDK 21, so we can be confident that we're compatible with old codebases and also with latest ones (by using the latest LTS).

On sbt-typelevel usage

I've removed the redundant dependencies already defined by sbt-typelevel.

Also, this is the first step to use sbt-typelevel-site for publishing the website. This first iteration only uses the transitive mdoc and everything else stays the same (Docusaurus), but we're now in a good position to use the standard typelevel way for websites.

@aartigao aartigao merged commit 06c249c into fd4s:series/3.x Feb 19, 2024
8 checks passed
@aartigao aartigao deleted the mdoc-from-sbt-typelevel-site branch February 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants