Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instances public, add fs2Kafka prefix to their names #473

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

bplommer
Copy link
Member

These instances are pretty generic and are useful for clients, especially as some public methods take e.g. NonEmptySet[TopicPartition] which requires an Order instance.

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #473 (09bb4cc) into master (35c49bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          63       63           
  Lines        1467     1467           
  Branches       44       45    +1     
=======================================
  Hits         1312     1312           
  Misses        155      155           
Impacted Files Coverage Δ
...main/scala/fs2/kafka/CommitRecoveryException.scala 100.00% <ø> (ø)
.../main/scala/fs2/kafka/CommitTimeoutException.scala 100.00% <ø> (ø)
...e/src/main/scala/fs2/kafka/CommittableOffset.scala 100.00% <ø> (ø)
.../main/scala/fs2/kafka/CommittableOffsetBatch.scala 66.66% <ø> (ø)
.../core/src/main/scala/fs2/kafka/KafkaConsumer.scala 98.69% <ø> (ø)
...core/src/main/scala/fs2/kafka/ProducerResult.scala 100.00% <ø> (ø)
...ules/core/src/main/scala/fs2/kafka/instances.scala 100.00% <ø> (ø)
.../scala/fs2/kafka/internal/KafkaConsumerActor.scala 79.85% <ø> (ø)
...e/src/main/scala/fs2/kafka/internal/LogEntry.scala 27.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c49bc...09bb4cc. Read the comment docs.

@bplommer bplommer marked this pull request as ready for review January 17, 2021 12:53
@bplommer bplommer requested a review from vlovgr January 17, 2021 12:53
@bplommer bplommer changed the base branch from master to series/1.3.x January 17, 2021 16:06
@bplommer bplommer added this to the v1.3.0 milestone Jan 17, 2021
@bplommer bplommer changed the base branch from series/1.3.x to series/1.4.x January 18, 2021 10:05
@bplommer bplommer merged commit ead5f44 into series/1.4.x Jan 18, 2021
@bplommer bplommer deleted the make-instances-public branch January 18, 2021 13:36
@bplommer bplommer mentioned this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants