Move deserialization from KafkaConsumerActor to KafkaConsumer #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplommer
changed the title
bplommer
changed the title
|
I think I'll go ahead and merge this with the behaviour change, but put out a release candidate before the next version to give a chance to test it in the wild. |
I think we should change the behavior. |
|
Meaning - you think we should release the change from this PR as-is? |
Yes. I don't think that the current behavior could be considered by someone as an intended or as a "feature". |
bplommer
added a commit
that referenced
this pull request
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postpones deserialising records until they are pushed onto a consumer stream, reducing the complexity of
KafkaConsumerActor.This means that a deserialization error in a partitioned stream will cause only the specific partition stream to fail, rather than crash the actor - I think that's a good thing, but maybe we should reproduce the existing behaviour (with a configurable toggle) in the 2.x series?