Use permit for fetch, rework permits #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplommer
commented
Mar 27, 2022
vlovgr
approved these changes
Mar 28, 2022
LMnet
reviewed
Mar 28, 2022
| } | ||
|
|
||
| def storeFetch: F[Unit] = | ||
| actor.ref.modify { state => |
There was a problem hiding this comment.
Looks a bit weird that we need to modify internal actor state from the another component.
There was a problem hiding this comment.
Yeah, I guess it's an artifact of an iterative transition away from having the actor be a separate encapsulated component. Maybe we should reconceptualise the state as "consumer state" rather than "actor state".
There was a problem hiding this comment.
Up to you. I mentioned it only to make sure that this is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.