Update testcontainers version, set image name and version explicitly #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplommer
commented
Mar 28, 2022
| @@ -6,7 +6,7 @@ | |||
| </encoder> | |||
| </appender> | |||
|
|
|||
| <root level="ERROR" additivity="false"> | |||
| <root level="INFO" additivity="false"> | |||
There was a problem hiding this comment.
This makes logs a lot noisier but I think it's more likely to be what you want if you're actually trying to track down a problem in them.
bplommer
commented
Mar 28, 2022
| @@ -66,7 +66,15 @@ abstract class BaseKafkaSpec extends BaseAsyncSpec with ForEachTestContainer { | |||
|
|
|||
| override def runTest(testName: String, args: Args) = super.runTest(testName, args) | |||
|
|
|||
| override val container: KafkaContainer = new KafkaContainer() | |||
| private val imageVersion = "7.0.1" | |||
There was a problem hiding this comment.
Ideally we'd test against both the earliest and latest supported version
bplommer
force-pushed
the
set-image-version
branch
from
8eb6c27 to
5272208
Compare
LMnet
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for running tests on Arm64