Use a shared test container for each suite #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplommer
commented
Mar 29, 2022
| @@ -66,7 +66,7 @@ final class KafkaConsumerSpec extends BaseKafkaSpec { | |||
| } | |||
| } | |||
|
|
|||
| it("should consume all records with subscribing for several consumers") { | |||
| it("should consume all records at least once with subscribing for several consumers") { | |||
There was a problem hiding this comment.
This was flaking before (#486) but changing to foralltestcontainer made it fail consistently. I think we should change the test to not expect exactly-once delivery.
bplommer
changed the title
bplommer
commented
Mar 29, 2022
| }) | ||
| _ <- IO(assert(topicNamesToListings.size == 1)) | ||
| topicNames <- adminClient.listTopics.names | ||
| topicCount = topicNames.size |
There was a problem hiding this comment.
Instead of having a fixed expectation of how many topics there should be, we check how many there are at the start and then generate other expectations relative to that.
vlovgr
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces CI time from ~16m to ~9m. Also opens the way for further huge speedup by paralellizing with weaver-test.