Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose creation of compat checker #988

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Expose creation of compat checker #988

merged 2 commits into from
Oct 16, 2023

Conversation

keirlawson
Copy link
Contributor

Expose compatibility checker creation for use compositionally

for example

val loadSchemaRegistrySettings: IO[SchemaRegistryClientSettings[IO]] = ???

val checker = ResourceSuiteLocalFixture(
    "my-fixture",
    Resource.eval(loadSchemaRegistrySettings.flatMap(newCompatibilityChecker(_)))
  )

@bplommer bplommer added this to the v2.6.0 milestone Jul 14, 2022
@aartigao aartigao removed this from the v2.6.0 milestone Oct 15, 2023
@aartigao
Copy link
Contributor

LGTM! Update PR to target series/3.x and I'll give it 👍🏽

@aartigao aartigao mentioned this pull request Oct 15, 2023
Merged
@keirlawson keirlawson force-pushed the expose-checker-construction branch from 28c775f to f443674 Compare October 15, 2023 15:16
@keirlawson keirlawson changed the base branch from series/2.x to series/3.x October 15, 2023 15:17
@keirlawson
Copy link
Contributor Author

Done!

@aartigao aartigao merged commit e8c6339 into fd4s:series/3.x Oct 16, 2023
1 check passed
@aartigao aartigao mentioned this pull request Oct 16, 2023
Merged
@keirlawson keirlawson deleted the expose-checker-construction branch October 16, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keirlawson @aartigao @bplommer