Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Codec.union to not require type tag #126

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented Jan 6, 2020

This pull request effectively limits the use of type tags to the Codec.derive* functions.

@codecov-io
Copy link

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         733    737    +4     
  Branches       30     28    -2     
=====================================
+ Hits          733    737    +4
Impacted Files Coverage Δ
...les/core/src/main/scala/vulcan/internal/tags.scala 100% <ø> (ø) ⬆️
...eneric/src/main/scala/vulcan/generic/package.scala 100% <100%> (ø) ⬆️
modules/core/src/main/scala/vulcan/Codec.scala 100% <100%> (ø) ⬆️
modules/core/src/main/scala/vulcan/AvroError.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c0236...13f8f66. Read the comment docs.

@vlovgr vlovgr merged commit 42f6c63 into master Jan 7, 2020
@vlovgr vlovgr deleted the remove-union-type-tag branch January 7, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants