Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Codec.enum and Codec.fixed parameters #128

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Reorder Codec.enum and Codec.fixed parameters #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/core/src/main/scala/vulcan/Codec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,13 +449,13 @@ final object Codec {
*/
final def enum[A](
name: String,
namespace: String,
symbols: Seq[String],
encode: A => String,
decode: String => Either[AvroError, A],
namespace: String,
aliases: Seq[String] = Seq.empty,
doc: Option[String] = None,
default: Option[A] = None,
doc: Option[String] = None,
aliases: Seq[String] = Seq.empty,
props: Props = Props.empty
): Codec[A] = {
val typeName = if (namespace.isEmpty) name else s"$namespace.$name"
Expand Down Expand Up @@ -535,12 +535,12 @@ final object Codec {
*/
final def fixed[A](
name: String,
namespace: String,
size: Int,
encode: A => Array[Byte],
decode: Array[Byte] => Either[AvroError, A],
namespace: String,
aliases: Seq[String] = Seq.empty,
doc: Option[String] = None,
aliases: Seq[String] = Seq.empty,
props: Props = Props.empty
): Codec[A] = {
val typeName = if (namespace.isEmpty) name else s"$namespace.$name"
Expand Down