Change to override Prism behaviour for Option #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following example fails with a
ClassCastException
on v1.0.1.This is because the
Prism
instance forOption
is derived usingClassTag
, which (due to type erasure) considersSome[A] <: Option[S]
, regardless ofA
. This pull request solves the issue by creating explicit behaviour forOption
. It does however not solve the issue more generally, and other parametric types still suffer from this issue.