Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codec#Repr type member to improve type safety of encoding #272

Merged
merged 8 commits into from
Feb 3, 2021
Merged

Add Codec#Repr type member to improve type safety of encoding #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc05f7a
narrow type ef `encode` from `Any` to `AnyRef`
bplommer Jan 28, 2021
1bef917
Add Repr type to codec
bplommer Jan 28, 2021
9b765e7
use Aux types for codecs
bplommer Jan 28, 2021
8f4a6d5
narrow type we encode Array as
bplommer Jan 28, 2021
f1cc6bb
reverse order of Aux parameters
bplommer Jan 28, 2021
753afa8
cleanup
bplommer Jan 28, 2021
19329c4
refactoring
bplommer Jan 29, 2021
d6f974a
Fix compiler errors in scala 2.12, use more Aux types
bplommer Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/core/src/main/scala-2/vulcan/CodecCompat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

package vulcan

import org.apache.avro.generic.GenericFixed
import scala.reflect.runtime.universe.WeakTypeTag
import vulcan.internal.tags._

Expand All @@ -20,7 +21,7 @@ private[vulcan] trait CodecCompanionCompat {
symbols: Seq[String],
encode: A => String,
decode: String => Either[AvroError, A]
)(implicit tag: WeakTypeTag[A]): Codec[A] =
)(implicit tag: WeakTypeTag[A]): Codec.Aux[AnyRef, A] =
Codec.enumeration(
name = nameFrom(tag),
symbols = symbols,
Expand All @@ -39,7 +40,7 @@ private[vulcan] trait CodecCompanionCompat {
size: Int,
encode: A => Array[Byte],
decode: Array[Byte] => Either[AvroError, A]
)(implicit tag: WeakTypeTag[A]): Codec[A] =
)(implicit tag: WeakTypeTag[A]): Codec.Aux[GenericFixed, A] =
Codec.fixed(
name = nameFrom(tag),
size = size,
Expand Down
Loading