Refactor native-http port

src/ports/native-http/index.ts

@@ -6,7 +6,12 @@ import { app } from './server'
 const PORT = env('PORT')
 
 export function start () {
-  http
-    .createServer(app)
-    .listen(PORT, () => console.log(`Server is listening on port ${PORT}`))
+  return new Promise((resolve) => {
+    http
+      .createServer(app)
+      .listen(PORT, () => {
+        console.log(`Server is listening on port ${PORT}`)
+        resolve(null)
+      })
+  })
 }

src/ports/native-http/middlewares.ts

@@ -9,9 +9,9 @@ export const withAuth: WithAuthMiddleware = (handler) => {
     pipe(
       authMiddleware(request.headers.authorization),
       TE.map(
-        async (payload) => {
+        (payload) => {
           request.auth = payload
-          await handler(request, response)
+          return handler(request, response)
         },
       ),
       TE.mapLeft(
@@ -26,15 +26,15 @@ export const withTryAuth: WithAuthMiddleware = (handler) => {
     pipe(
       authMiddleware(request.headers.authorization),
       TE.map(
-        async (payload) => {
+        (payload) => {
           request.auth = payload
-          await handler(request, response)
+          return handler(request, response)
         },
       ),
       TE.mapLeft(
-        async () => {
+        () => {
           request.auth = undefined
-          await handler(request, response)
+          return handler(request, response)
         },
       ),
     )()

src/ports/native-http/modules/article.ts

@@ -1,4 +1,4 @@
-import { pipe } from 'fp-ts/function'
+import { pipe, identity } from 'fp-ts/function'
 import * as E from 'fp-ts/Either'
 import * as TE from 'fp-ts/TaskEither'
 import * as article from '@/ports/adapters/http/modules/article'
@@ -16,10 +16,7 @@ const getPropFromRequestBody: GetPropFromRequestBody = (data, prop) => {
       () => JSON.parse(data),
       E.toError,
     ),
-    E.fold(
-      (error) => error,
-      (body) => body[prop] || {},
-    ),
+    E.fold(identity, (body) => body[prop] ?? {}),
   )
 }
 
@@ -48,7 +45,7 @@ const articleRoutes: Routes = {
 
     pipe(
       article.fetchArticle({
-        slug: request.params![slug] ?? '',
+        slug: request.params?.[slug] ?? '',
         userId: payload.id,
       }),
       TE.map(result => httpResponse(response, result)),
@@ -76,7 +73,7 @@ const articleRoutes: Routes = {
     for await (const body of request) {
       const data: UpdateArticle = {
         ...getPropFromRequestBody<UpdateArticle>(body, 'article'),
-        slug: request.params![slug] as Slug,
+        slug: request.params?.[slug] as Slug,
         authorId: payload.id,
       }
 
@@ -95,7 +92,7 @@ const articleRoutes: Routes = {
 
     pipe(
       article.deleteArticle({
-        slug: request.params![slug] ?? '',
+        slug: request.params?.[slug] ?? '',
         userId: payload.id,
       }),
       TE.map(() => httpResponse(response)),
@@ -123,7 +120,7 @@ const articleRoutes: Routes = {
     pipe(
       article.favoriteArticle({
         userId: payload.id,
-        slug: request.params![slug] ?? '',
+        slug: request.params?.[slug] ?? '',
       }),
       TE.map(result => httpResponse(response, result)),
       TE.mapLeft(result => httpResponse(response, result.error, result.code)),
@@ -137,7 +134,7 @@ const articleRoutes: Routes = {
     pipe(
       article.unfavoriteArticle({
         userId: payload.id,
-        slug: request.params![slug] ?? '',
+        slug: request.params?.[slug] ?? '',
       }),
       TE.map(result => httpResponse(response, result)),
       TE.mapLeft(result => httpResponse(response, result.error, result.code)),
@@ -152,7 +149,7 @@ const articleRoutes: Routes = {
       const data: CreateComment = {
         ...getPropFromRequestBody<CreateComment>(body, 'comment'),
         authorId: payload.id,
-        articleSlug: request.params![slug] as Slug,
+        articleSlug: request.params?.[slug] as Slug,
       }
 
       pipe(
@@ -169,7 +166,7 @@ const articleRoutes: Routes = {
     const slug = 'slug'
 
     const data = {
-      slug: request.params![slug] ?? '',
+      slug: request.params?.[slug] ?? '',
       userId: payload.id,
     }
 
@@ -187,8 +184,8 @@ const articleRoutes: Routes = {
     const id = 'id'
 
     const data = {
-      commentId: Number(request.params![id]),
-      slug: request.params![slug] ?? '',
+      commentId: Number(request.params?.[id]),
+      slug: request.params?.[slug] ?? '',
       userId: payload.id,
     }
 

src/ports/native-http/modules/profile.ts

@@ -12,7 +12,7 @@ const profileRoutes: Routes = {
 
     pipe(
       user.getProfile({
-        username: request.params![username] ?? '',
+        username: request.params?.[username] ?? '',
         userId: payload.id,
       }),
       TE.map(result => httpResponse(response, result)),
@@ -26,7 +26,7 @@ const profileRoutes: Routes = {
 
     pipe(
       user.followUser({
-        userToFollow: request.params![username] ?? '',
+        userToFollow: request.params?.[username] ?? '',
         userId: payload.id,
       }),
       TE.map(result => httpResponse(response, result)),
@@ -40,7 +40,7 @@ const profileRoutes: Routes = {
 
     pipe(
       user.unfollowUser({
-        userToUnfollow: request.params![username] ?? '',
+        userToUnfollow: request.params?.[username] ?? '',
         userId: payload.id,
       }),
       TE.map(result => httpResponse(response, result)),

src/ports/native-http/modules/user.ts

@@ -1,4 +1,4 @@
-import { pipe } from 'fp-ts/function'
+import { pipe, identity } from 'fp-ts/function'
 import * as E from 'fp-ts/Either'
 import * as TE from 'fp-ts/TaskEither'
 import * as user from '@/ports/adapters/http/modules/user'
@@ -14,10 +14,7 @@ const getUserFromRequestBody: GetUserFromRequestBody = (data) => {
       () => JSON.parse(data),
       E.toError,
     ),
-    E.fold(
-      (error) => error,
-      (body) => body.user || {},
-    ),
+    E.fold(identity, (body) => body.user ?? {}),
   )
 }