Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter type of Any::try_pack. #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ik1ne
Copy link

@ik1ne ik1ne commented Aug 21, 2023

Implements #48.
This is a breaking change, which might be undesired.
A possible workaround would be to implement a new function called try_pack_by_ref(&T) alongside with current try_pack(T).

@fdeantoni
Copy link
Owner

Many thanks for putting together this PR! I will review and see what the best way forward is. I agree it might be best to avoid a breaking change and have a new method try_unpack_by_ref or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants