Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow libavif to install rav1e, except on manylinux2014 and aarch64 #7

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

radarhere
Copy link

@radarhere radarhere commented Dec 6, 2024

Suggestion for python-pillow#5201

I presume the reason that you didn't just use "LOCAL" for rav1e is that some dependencies were missing.

This will allow libavif to install rav1e itself - except on manylinux2014, where an initial attempt found a problem with perl, and aarch64, where the time taken was excessive. However, manylinux2014 will only be needed for a few more months, and aarch64 might become faster in the near future.

@radarhere radarhere mentioned this pull request Dec 6, 2024
@fdintino
Copy link
Owner

fdintino commented Dec 7, 2024

Up until 8 months ago I was installing build dependencies and building rav1e in pillow-avif-plugin, but I switched to the pre-built binaries because it takes an eternity to build it in qemu virtualization. This was the workaround I had for the perl issue

https://github.com/fdintino/pillow-avif-plugin/blob/616b64091fc3ec217c0458262ffcb5d22ce9d792/wheelbuild/config.sh#L417-L419

Since the performance issues forced me to use pre-built binaries for aarch64, I figured it was simpler to do so for all environments. But at the time there wasn't a LOCAL build option in libavif; I'm actually the one who added it. Now that it exists I don't think there's any reason not to build it.

@fdintino fdintino merged commit 9ad8311 into fdintino:libavif-plugin Dec 7, 2024
66 of 67 checks passed
@radarhere radarhere deleted the build_rav1e branch December 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants