-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add konflux test cases #688
Conversation
not really, they can start independently but the value of testing them w/o the full flow is not high (to me, it's good but not high)
yes |
Hi @yih-redhat, according to https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167#note_13160582, I think this PR needs to be landed first, then https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167. |
That would certainly be a best scenario, however if you expect this PR to be merged within few hours I can approve the configuration one (and merge it) ASAP. The main risk is that automated MR (caused by Konflux references updates or package updates) are merge now automatically, which would stop if the tests suddenly do not pass |
Thanks for starting on this @yih-redhat! I would love to see some additional documentation or inline comments explaining some of what is happening in these tests. For example, it is surprising to see the use of I just want to avoid the situation where a new contributor to this repo finds these files and has no context about why they are here, what they do, etc. |
81ba445
to
bfbeb2b
Compare
Hi @miabbott , I have add a README file in this konflux folder to explain why we created these files and what they do, and also explained the workflow that konflux use these files to run integration test. Please let me know if I miss anything here. |
bfbeb2b
to
bfd6e1b
Compare
bfd6e1b
to
2e4e1b6
Compare
2e4e1b6
to
9b40777
Compare
To enable integration test in konflux, this pr added test cases that will be triggered by konflux mr https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167
This pr only includes simple check for those containers, after this pr and related konflux mr get merged, I can start to trigger the workflow and debug errors. After the whole konflux integration test workflow is verified, more test cases can be added later.
I have a concern:
konflux will build single fido container and trigger test, for example, it build manufacturing server container and then trigger test for manufacturing server. Konflux currently cannot build all fido containers at the same time and then trigger the test.
This brings two questions: