Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add konflux test cases #688

Merged
merged 1 commit into from
Oct 15, 2024
Merged

ci: add konflux test cases #688

merged 1 commit into from
Oct 15, 2024

Conversation

yih-redhat
Copy link

@yih-redhat yih-redhat commented Oct 14, 2024

To enable integration test in konflux, this pr added test cases that will be triggered by konflux mr https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167

This pr only includes simple check for those containers, after this pr and related konflux mr get merged, I can start to trigger the workflow and debug errors. After the whole konflux integration test workflow is verified, more test cases can be added later.

I have a concern:
konflux will build single fido container and trigger test, for example, it build manufacturing server container and then trigger test for manufacturing server. Konflux currently cannot build all fido containers at the same time and then trigger the test.
This brings two questions:

  1. If I remember correctly some fido container depends on other container to start, so if that fido container can not startup, we can only run some very simple checks.
  2. We need all fido containers up and running to run a full fido onboarding test, test each fido container separately does not make much sense.

@yih-redhat
Copy link
Author

@mmartinv @runcom could you please help to review this pull request? (sorry I don't know which one of you I should ask)

@runcom
Copy link
Contributor

runcom commented Oct 14, 2024

  1. If I remember correctly some fido container depends on other container to start, so if that fido container can not startup, we can only run some very simple checks.

not really, they can start independently but the value of testing them w/o the full flow is not high (to me, it's good but not high)

2. We need all fido containers up and running to run a full fido onboarding test, test each fido container separately does not make much sense.

yes

@henrywang
Copy link
Collaborator

@lukaszachy
Copy link

lukaszachy commented Oct 14, 2024

Hi @yih-redhat, according to https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167#note_13160582, I think this PR needs to be landed first, then https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2167.

That would certainly be a best scenario, however if you expect this PR to be merged within few hours I can approve the configuration one (and merge it) ASAP.

The main risk is that automated MR (caused by Konflux references updates or package updates) are merge now automatically, which would stop if the tests suddenly do not pass

@miabbott
Copy link
Contributor

Thanks for starting on this @yih-redhat!

I would love to see some additional documentation or inline comments explaining some of what is happening in these tests. For example, it is surprising to see the use of apk in the test (though I guess that is just the Testing Farm CLI container that is using Alpine Linux?).

I just want to avoid the situation where a new contributor to this repo finds these files and has no context about why they are here, what they do, etc.

@yih-redhat yih-redhat force-pushed the konflux-its branch 3 times, most recently from 81ba445 to bfbeb2b Compare October 15, 2024 05:51
@yih-redhat
Copy link
Author

Hi @miabbott , I have add a README file in this konflux folder to explain why we created these files and what they do, and also explained the workflow that konflux use these files to run integration test. Please let me know if I miss anything here.

konflux/fido-container-test.yaml Outdated Show resolved Hide resolved
konflux/fdo-manufacturing-server-integration-tests.yaml Outdated Show resolved Hide resolved
konflux/fdo-manufacturing-server-integration-tests.yaml Outdated Show resolved Hide resolved
konflux/README.md Outdated Show resolved Hide resolved
mmartinv
mmartinv previously approved these changes Oct 15, 2024
@mergify mergify bot merged commit 1276a73 into fdo-rs:main Oct 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants