Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dotenv pkg, env template #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added dotenv pkg, env template #2

wants to merge 1 commit into from

Conversation

abhi3700
Copy link

This code is running fine when cloned & parsed the required env variable.

cburgdorf
cburgdorf reviewed Jul 12, 2022
View reviewed changes
hardhat.config.js
accounts: [`${process.env.GOERLI_DEPLOYER_PK}`]
}
}
accounts: [`0x${process.env.GOERLI_DEPLOYER_PK}`],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumption is that the 0x part goes into the environment variable

cburgdorf
cburgdorf approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but I would prefer it to be updated so that the 0x part is assumed to be part of the environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburgdorf cburgdorf cburgdorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi3700 @cburgdorf