Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add permissions to auto-commit. #33

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

JavaRaf
Copy link
Contributor

@JavaRaf JavaRaf commented Nov 11, 2024

It is no longer necessary to activate

settings -> actions -> general -> read and write && allow approve pull request

Description

Please provide a brief description of your changes here.

Checklist

Setupping Frames:

  • I Have disabled the actions/init-banner.
  • I Have changed the frameiterator file to 1.
  • I Have setupped the config.conf.
  • I Have deleted the old frames and replaced the new frames.
  • I Have created a new Album and get the Album ID (optional).
  • I Have setupped the subtitles (optional).

QA: After you pushed the changes:

  • Have you enabled actions/init-banner?
  • I Have confimed it is working.
  • Is it visible to public?

Checklist for Feats

Please review and complete these items before submitting your pull request:

  • I have tested my changes thoroughly and they work as expected.
  • I have included appropriate tests for any new features or bug fixes.
  • My code is well-formatted and complies with the ShellCheck standards.
  • I have updated the documentation (if applicable).
  • I have read and agree to the code of conduct and contribution guidelines.

It is no longer necessary to activate

settings -> actions -> general -> read and write && allow approve pull request
@JavaRaf JavaRaf requested a review from Rendevior as a code owner November 11, 2024 18:54
@JavaRaf
Copy link
Contributor Author

JavaRaf commented Nov 11, 2024

Prevents the error of forgetting read and write permissions for the github interface.

Prevents the bot from looping by never updating the frameiterator

I tested it in another repository
image
image

I've only given permissions to workflows that make commits, the others don't seem to need writing, only reading which is already standard

complement to the previous commit that adds permissions by yml
@fearocanity fearocanity merged commit 713a043 into fearocanity:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants