Skip to content

Commit

Permalink
Publish datatypes/java along with sdk/java (#426)
Browse files Browse the repository at this point in the history
This forward-ports a straggling commit from #407: it was missed when
initially creating the datatypes module because Sonatype publishing
setup was added concurrently.
  • Loading branch information
ches authored and feast-ci-bot committed Jan 9, 2020
1 parent 20ce16e commit 2a33f7b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .prow/scripts/publish-java-sdk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ gpg --import --batch --yes $GPG_KEY_IMPORT_DIR/private-key
echo "============================================================"
echo "Deploying Java SDK with revision: $REVISION"
echo "============================================================"
mvn --projects sdk/java -Drevision=$REVISION --batch-mode clean deploy
mvn --projects datatypes/java,sdk/java -Drevision=$REVISION --batch-mode clean deploy
20 changes: 16 additions & 4 deletions datatypes/java/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ Dependency Coordinates
</dependency>
```

Use the version corresponding to the Feast release you have deployed in your
environment—see the [Feast release notes] for details.

[Feast release notes]: ../../CHANGELOG.md

Using the `.proto` Definitions
------------------------------

Expand All @@ -36,8 +41,15 @@ either for `include` or to compile with a different `protoc` plugin than Java.
[Gradle]: https://github.com/google/protobuf-gradle-plugin#protos-in-dependencies
[sbt-protoc]: https://github.com/thesamet/sbt-protoc

Publishing
----------
Releases
--------

The module is published to Maven Central upon each release of Feast (since
v0.3.7).

For developers, the publishing process is automated along with the Java SDK by
[the `publish-java-sdk` build task in Prow][prow task], where you can see how
it works. Artifacts are staged to Sonatype where a maintainer needs to take a
release action for them to go live on Maven Central.

TODO: this module should be published to Maven Central upon Feast releases—this
needs to be set up in POM configuration and release automation.
[prow task]: https://github.com/gojek/feast/blob/17e7dca8238aae4dcbf0ff9f0db5d80ef8e035cf/.prow/config.yaml#L166-L192

0 comments on commit 2a33f7b

Please sign in to comment.