Skip to content

Commit

Permalink
Add missing kafka port in example feast stream config
Browse files Browse the repository at this point in the history
Incorrectly swapped resources requests and limit
  • Loading branch information
davidheryanto committed Mar 13, 2020
1 parent c54faf4 commit 2a728db
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions infra/charts/feast/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ feast-core:
feast:
stream:
options:
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
jobs:
runner: DataflowRunner
options:
Expand Down Expand Up @@ -355,9 +355,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
feast-online-serving:
javaOpts: "-Xms2048m -Xmx2048m"
resources:
requests:
memory: "4096Mi"
limits:
memory: "4096Mi"
requests:
memory: "2048Mi"
cpu: "2"
```
Expand Down
6 changes: 3 additions & 3 deletions infra/charts/feast/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ feast-core:
feast:
stream:
options:
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
jobs:
runner: DataflowRunner
options:
Expand Down Expand Up @@ -342,9 +342,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
feast-online-serving:
javaOpts: "-Xms2048m -Xmx2048m"
resources:
requests:
memory: "4096Mi"
limits:
memory: "4096Mi"
requests:
memory: "2048Mi"
cpu: "2"
```
Expand Down
2 changes: 1 addition & 1 deletion infra/charts/feast/values-dataflow-runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ feast-core:
feast:
stream:
options:
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
jobs:
runner: DataflowRunner
options:
Expand Down

0 comments on commit 2a728db

Please sign in to comment.