Skip to content

Commit

Permalink
Fix fastavro version used in Feast to avoid Timestamp delta error (#490)
Browse files Browse the repository at this point in the history
* Fix fastavro version used in feast to 0.22.9

* Print python packages version used when e2e test fails

(cherry picked from commit 7586da6)
  • Loading branch information
davidheryanto authored and zhilingc committed Feb 26, 2020
1 parent 601033f commit 2d38c4e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .prow/scripts/test-end-to-end-batch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ set +e
pytest bq-batch-retrieval.py --junitxml=${LOGS_ARTIFACT_PATH}/python-sdk-test-report.xml
TEST_EXIT_CODE=$?

if [[ ${TEST_EXIT_CODE} != 0 ]]; then
echo "[DEBUG] Printing logs"
ls -ltrh /var/log/feast*
cat /var/log/feast-serving-warehouse.log /var/log/feast-core.log

echo "[DEBUG] Printing Python packages list"
pip list
fi

cd ${ORIGINAL_DIR}
exit ${TEST_EXIT_CODE}

Expand Down
9 changes: 9 additions & 0 deletions .prow/scripts/test-end-to-end.sh
Original file line number Diff line number Diff line change
Expand Up @@ -225,5 +225,14 @@ set +e
pytest basic-ingest-redis-serving.py --junitxml=${LOGS_ARTIFACT_PATH}/python-sdk-test-report.xml
TEST_EXIT_CODE=$?

if [[ ${TEST_EXIT_CODE} != 0 ]]; then
echo "[DEBUG] Printing logs"
ls -ltrh /var/log/feast*
cat /var/log/feast-serving-online.log /var/log/feast-core.log

echo "[DEBUG] Printing Python packages list"
pip list
fi

cd ${ORIGINAL_DIR}
exit ${TEST_EXIT_CODE}
4 changes: 3 additions & 1 deletion sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
"pandavro==1.5.*",
"protobuf>=3.10",
"PyYAML==5.1.*",
"fastavro==0.*",
# fastavro 0.22.10 and newer will throw this error for e2e batch test:
# TypeError: Timestamp subtraction must have the same timezones or no timezones
"fastavro==0.22.9",
"kafka-python==1.*",
"tabulate==0.8.*",
"toml==0.10.*",
Expand Down

0 comments on commit 2d38c4e

Please sign in to comment.