fetch job labels from dataflow

feast-dev · Sep 1, 2020 · 2f0c9e9 · 2f0c9e9
1 parent a926e6f
commit 2f0c9e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/job-controller/src/main/java/feast/jobcontroller/runner/dataflow/DataflowJobManager.java b/job-controller/src/main/java/feast/jobcontroller/runner/dataflow/DataflowJobManager.java
@@ -304,6 +304,10 @@ public List<Job> listRunningJobs() {
                       .setStores(
                           stores.stream()
                               .collect(Collectors.toMap(StoreProto.Store::getName, s -> s)))
+                      .setLabels(
+                          dfJob.getLabels() == null
+                              ? new HashMap<>()
+                              : new HashMap<>(dfJob.getLabels()))
                       .build();
 
               job.setExtId(dfJob.getId());

diff --git a/job-controller/src/test/java/feast/jobcontroller/runner/dataflow/DataflowJobManagerTest.java b/job-controller/src/test/java/feast/jobcontroller/runner/dataflow/DataflowJobManagerTest.java
@@ -275,7 +275,8 @@ public void shouldRetrieveRunningJobsFromDataflow() {
                 hasProperty("stores", hasValue(store)),
                 hasProperty("extId", equalTo("job-2")),
                 hasProperty("created", equalTo(created.toDate())),
-                hasProperty("lastUpdated", equalTo(created.toDate())))));
+                hasProperty("lastUpdated", equalTo(created.toDate())),
+                hasProperty("labels", hasEntry("application", "feast")))));
   }
 
   @Test