features list is optional

Signed-off-by: Rob Howley <howley.robert@gmail.com>
feast-dev · Oct 30, 2024 · 3025386 · 3025386
1 parent 94594ea
commit 3025386
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -71,7 +71,7 @@ class MaterializeIncrementalRequest(BaseModel):
 class GetOnlineFeaturesRequest(BaseModel):
     entities: Dict[str, List[Any]]
     feature_service: Optional[str] = None
-    features: List[str] = Field(default_factory=list)
+    features: Optional[List[str]] = Field(default_factory=list)
     full_feature_names: bool = False
 
 
@@ -252,8 +252,8 @@ def materialize(request: MaterializeRequest):
         for feature_view in request.feature_views or []:
             # TODO: receives a str for resource but isn't in the Union. is str actually allowed?
             assert_permissions(
-                resource=feature_view,
-                actions=[AuthzedAction.WRITE_ONLINE],  # type: ignore
+                resource=feature_view,  # type: ignore
+                actions=[AuthzedAction.WRITE_ONLINE],
             )
         store.materialize(
             utils.make_tzaware(parser.parse(request.start_ts)),
@@ -266,8 +266,8 @@ def materialize_incremental(request: MaterializeIncrementalRequest):
         for feature_view in request.feature_views or []:
             # TODO: receives a str for resource but isn't in the Union. is str actually allowed?
             assert_permissions(
-                resource=feature_view,
-                actions=[AuthzedAction.WRITE_ONLINE],  # type: ignore
+                resource=feature_view,  # type: ignore
+                actions=[AuthzedAction.WRITE_ONLINE],
             )
         store.materialize_incremental(
             utils.make_tzaware(parser.parse(request.end_ts)), request.feature_views