Update Feast installation doc (#207)

* Update start command in Docker image
In newer official images of java the absolute path of java is no longer /usr/bin/java

* Update default values.yaml, secret config and resource request

* Update feast installation quickstart doc

* Add comment to FEAST_POSTGRES_PASSWORD variable

* Add comment for FEAST_STAGING_LOCATION_GCS_URI

* Make comment clearer for setting core and serving uri

* Add missing syntax declaration for code block

* Make comment clearer when setting core,serving uri

* Update comment for 'feast config set'

* Fix case

* Make comment clearer when setting uri

* Fix core-deploy.yaml
Use template postgresql.secretName to retrieve DB_PASSWORD

* Fix typo

* Update description of feast usage of gcp services

* Update description for setting variables

* Fix gcloud container create arguments

* Update required roles for feast admin and nat router requirement

* Update GCP_REGION options

* Set default value for core.jobs.runner to DirectRunner in helm chart

Dockerfiles/core/Dockerfile

@@ -10,7 +10,7 @@ ARG REVISION=dev
 COPY --from=builder /build/core/target/feast-core-$REVISION.jar /usr/share/feast/feast-core.jar
 COPY --from=builder /build/ingestion/target/feast-ingestion-$REVISION.jar /usr/share/feast/feast-ingestion.jar
 ENV JOB_EXECUTABLE=/usr/share/feast/feast-ingestion.jar
-ENTRYPOINT ["/usr/bin/java", \
+ENTRYPOINT ["java", \
 "-XX:+UnlockExperimentalVMOptions", \
 "-XX:+UseCGroupMemoryLimitForHeap", \
 "-jar", "/usr/share/feast/feast-core.jar"]

Dockerfiles/serving/Dockerfile

@@ -8,7 +8,7 @@ RUN mvn --projects serving -Drevision=$REVISION -DskipTests=true --batch-mode pa
 FROM openjdk:8-jre-alpine as production
 ARG REVISION=dev
 COPY --from=builder /build/serving/target/feast-serving-$REVISION.jar /usr/share/feast/feast-serving.jar
-ENTRYPOINT ["/usr/bin/java", \
+ENTRYPOINT ["java", \
       "-XX:+UseG1GC", \
       "-XX:+UseStringDeduplication", \
       "-XX:+UnlockExperimentalVMOptions", \

charts/feast/templates/_helpers.tpl

@@ -64,13 +64,6 @@ If release name contains chart name it will be used as a full name.
 {{- end -}}
 {{- end -}}
 
-{{/*
-Generate postgresql secret name
-*/}}
-{{- define "postgresql.secretName" -}}
-{{ default (include "postgresql.fullname" .) .Values.existingSecret }}
-{{- end -}}
-
 {{/*
 Create chart name and version as used by the chart label.
 */}}

charts/feast/templates/core-deploy.yaml

@@ -1,4 +1,4 @@
-apiVersion: extensions/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: {{ template "feast.core.name" . }}
@@ -11,6 +11,11 @@ metadata:
     heritage: {{ .Release.Service }}
 spec:
   replicas: {{ .Values.core.replicaCount }}
+  selector:
+    matchLabels:
+      app: {{ template "feast.name" . }}
+      component: core
+      release: {{ .Release.Name }}
   strategy:
     type: RollingUpdate
     rollingUpdate:
@@ -75,7 +80,7 @@ spec:
           - name: DB_PASSWORD
             valueFrom:
               secretKeyRef:
-                name: {{ template "postgresql.fullname" . }}
+                name: {{ template "postgresql.secretName" . }}
                 key: postgresql-password
           - name: LOG_TYPE
             value: {{ .Values.core.logType }}

charts/feast/templates/serving-deploy.yaml

@@ -1,4 +1,4 @@
-apiVersion: extensions/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: {{ template "feast.serving.name" . }}
@@ -11,6 +11,11 @@ metadata:
     heritage: {{ .Release.Service }}
 spec:
   replicas: {{ .Values.serving.replicaCount }}
+  selector:
+    matchLabels:
+      app: {{ template "feast.name" . }}
+      component: serving
+      release: {{ .Release.Name }}
   strategy:
     type: RollingUpdate
     rollingUpdate:
@@ -72,7 +77,7 @@ spec:
           - name: STORE_SERVING_TYPE
             value: {{ .Values.store.serving.type }}
           - name: STORE_SERVING_OPTIONS
-            value: {{ .Values.store.serving.options | toJson}}
+            value: {{ .Values.store.serving.options | toJson }}
           - name: FEAST_MAX_NB_THREAD
             value: "{{ .Values.serving.config.maxNumberOfThread }}"
           - name: FEAST_MAX_ENTITY_PER_BATCH
@@ -84,7 +89,7 @@ spec:
           - name: FEAST_REDIS_POOL_MAX_IDLE
             value: "{{ .Values.serving.config.redisPool.maxIdle }}"
           - name: STATSD_HOST
-            value: {{ .Values.statsd.host }}
+            value: "{{ .Values.statsd.host }}"
           - name: STATSD_PORT
             value: "{{ .Values.statsd.port }}"
           {{- if .Values.serving.jaeger.enabled }}

charts/feast/values.yaml

@@ -10,10 +10,10 @@ core:
   resources: 
     limits: 
       cpu: 4
-      memory: 8G
+      memory: 6G
     requests: 
-      cpu: 2
-      memory: 4G
+      cpu: 1
+      memory: 2G
   rollingUpdate: 
     maxSurge: 2
     maxUnavailable: 0
@@ -30,6 +30,7 @@ core:
     # loadBalancerSourceRanges: ["10.0.0.0/8"]
   jobs:
     workspace: "/tmp"
+    # runner specifies the Beam pipeline runner, use either DirectRunner (for development) or DataflowRunner (for production)
     runner: DirectRunner
     options: "{}"
     errorStoreType: "stdout"
@@ -46,25 +47,30 @@ core:
     initialDelaySeconds: 60
     failureThreshold: 1
 
-#store:
-#  errors:
-#    type: "stdout"
-#  warehouse:
-#    type: "bigquery"
-#    options: '{"project": "gcp-project-id", "dataset": "feast"}'
-#  serving:
-#    type: "redis"
-#    options: '{"host": "...", "port": "6379"}'
+# dataflow configuration is required when core.jobs.runner=DataflowRunner
+# dataflow:
+#   projectID: ${GCP_PROJECT}
+#   location: ${GCP_REGION}
 
-# postgresql: 
-#   provision: true
-#   persistence:
-#     enabled: false
+store:
+ errors:
+   type: "stdout"
+ warehouse:
+   type: "bigquery"
+   # options: '{"project": "gcp-project-id", "dataset": "feast"}'
+ serving:
+   type: "redis"
+   # options: '{"host": "redis-master", "port": "6379"}'
+
+postgresql: 
+  provision: true
+  persistence:
+    enabled: true
 
-# redis:
-#   provision: true
-#   cluster:
-#     enabled: false
+redis:
+  provision: false
+  cluster:
+    enabled: false
 
 serving: 
   config: 
@@ -86,7 +92,7 @@ serving:
       memory: 4G
     requests: 
       cpu: 1
-      memory: 2G
+      memory: 1G
   rollingUpdate: 
     maxSurge: 2
     maxUnavailable: 0
@@ -107,14 +113,14 @@ serving:
     initialDelaySeconds: 120
     failureThreshold: 3
   readinessProbe:
-    initialDelaySeconds: 60
+    initialDelaySeconds: 30
     failureThreshold: 1
 
 # Enable only if you have an existing service account you 
 # want to mount the secret of.
 # serviceAccount:
 #   name: feast-service-account
-#   key: feast-service-account-key
+#   key: service-account.json
 
 statsd:
   host: "localhost"