Skip to content

Commit

Permalink
doc: Update the README to mention the contirbution from Expedia Group.
Browse files Browse the repository at this point in the history
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
  • Loading branch information
shuchu committed Nov 1, 2024
1 parent 90d32bf commit 37f39f2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
10 changes: 2 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -529,14 +529,8 @@ install-go-proto-dependencies:
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.3.0

install-go-ci-dependencies:
# TODO: currently gopy installation doesn't work w/o explicit go get in the next line
# TODO: there should be a better way to install gopy
go get github.com/go-python/gopy@v0.4.4
go install golang.org/x/tools/cmd/goimports
# The `go get` command on the previous lines download the lib along with replacing the dep to `feast-dev/gopy`
# but the following command is needed to install it for some reason.
go install github.com/go-python/gopy
python -m pip install "pybindgen==0.22.1" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"
# go install golang.org/x/tools/cmd/goimports
# python -m pip install "pybindgen==0.22.1" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"

build-go: compile-protos-go
go build -o feast ./go/main.go
Expand Down
3 changes: 3 additions & 0 deletions go/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[Update 10/31/2024] This Go feature server code is updated from the Expedia Group's forked Feast branch (https://github.com/EXPEbdodla/feast) on 10/22/2024. Thanks the engineers of the Expedia Groups who contributed and improved the Go feature server.


This directory contains the Go logic that's executed by the `EmbeddedOnlineFeatureServer` from Python.

## Build and Run
Expand Down

0 comments on commit 37f39f2

Please sign in to comment.